Remove blinded execution payload envelope - #11091
gfukushima merged 13 commits into
Conversation
…nvelope from PostExecutionPayloadEnvelope, and add `Eth-Blob-Data-Included` header to distiguish between ExecutionPayloadEnvelopeContents and ExecutionPayloadEnvelope when parsing request body Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Reviewed by Cursor Bugbot for commit 045ebea. Configure here.
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
| final SignedBlindedExecutionPayloadEnvelope signedBlindedExecutionPayload, | ||
| final Optional<BroadcastValidationLevel> broadcastValidationLevel) { | ||
| return SafeFuture.<SignedExecutionPayloadEnvelope>of( | ||
| return SafeFuture.<List<DataColumnSidecar>>of( |
There was a problem hiding this comment.
Should we abort the entire publish if we can't reconstruct blobs for it? Looks like previously we would still accept the valid signed envelope, and now we won't.
There was a problem hiding this comment.
looking into this, I think you're right, not having or being able to reconstruct should be reason enough to stop the publishing of the execution payload.
There was a problem hiding this comment.
I do believe the old behaviour was a bug since we a payload without it's sidecar is not valid, we were publishing a payload that would likely fail the import when the time to import come
…atch with the signed execution payload envelope Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
…sidecars Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
# Conflicts:
# data/beaconrestapi/src/integration-test/resources/tech/pegasys/teku/beaconrestapi/beacon/paths/_eth_v4_validator_blocks_{slot}.json
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
…d reject a payload mismatch Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
…velope' into remove-BlindedExecutionPayloadEnvelope
2 participants
PR Description
Remove the blinded version of execution payload envelope following the change in the beacon api ethereum/beacon-APIs#624
We now use
Eth-Blob-Data-Includedto distinguish the request body of publishExecutionPayloadEnvelopeFixed Issue(s)
Fixes #11044
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog
Note
High Risk
Breaking beacon API and validator publish behavior on a consensus-critical path (execution payloads, blob availability, gossip). Misconfigured headers or cross-node block production can cause 400 rejections instead of silent unblind failures.
Overview
Aligns Gloas execution payload publication with the updated beacon API by dropping
SignedBlindedExecutionPayloadEnvelopeand the unblind-from-cache path.Eth-Blob-Data-Includednow selects the body:true→SignedExecutionPayloadEnvelopeContents(blobs in the request),false→SignedExecutionPayloadEnvelope(beacon node attaches blobs/KZG proofs from block-production cache).Stateful publish builds data column sidecars from the cached
getPayloadresult, withDataColumnSidecarCreationExceptionfor missing cache or payload root mismatch (caller-safe rejection messages).ExecutionPayloadPublisherGloasruns sidecar creation in parallel with broadcast validation but does not gossip the envelope until sidecars are ready; if the block has no blob commitments, it may still publish with empty sidecars. Validator remote clients send the signed envelope directly withEth-Blob-Data-Included: falseinstead of blinding first.REST/OpenAPI, validator API channels, and failover blinded routing are updated accordingly;
produceBlockV4treatsinclude_payloadas a required query parameter.Reviewed by Cursor Bugbot for commit b66c5c4. Bugbot is set up for automated code reviews on this repo. Configure here.